Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge stable #7703

Merged
merged 5 commits into from
Nov 22, 2020
Merged

merge stable #7703

merged 5 commits into from
Nov 22, 2020

Conversation

MartinNowak
Copy link
Member

  • Fix Issue 21383 - std.random.uniform!T(urng) when T is dchar disregards urng and always uses a thread-local random
  • Fix Issue 21384 - std.random.uniform!T() and std.random.uniform!T(urng) when T is dchar with any qualifiers can exceed dchar.max
  • Fix Issue 21256 - Segfault with Appender!string.init.toString()

n8sh and others added 5 commits November 13, 2020 06:52
…ds urng and always uses a thread-local random
…g) when T is dchar with any qualifiers can exceed dchar.max
Fix problems with std.random.uniform!dchar(urng)
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Auto-close Bugzilla Severity Description
21256 critical Segfault with Appender!string.init.toString()
21383 normal std.random.uniform!T(urng) when T is dchar disregards urng and always uses a thread-local random
21384 normal std.random.uniform!T() and std.random.uniform!T(urng) when T is dchar with any qualifiers can exceed dchar.max

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7703"

@dlang-bot dlang-bot merged commit b6444f4 into dlang:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants