Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20539 - std.conv.to: internal overload conflict for enums with base types that have a catch-all opEquals overload (?) #7749

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Jan 17, 2021

This is a copy of #7378. I'm the original author, but as I deleted my old account, I can't do any changes there.

I rebased and replaced "issue 20539" by a link to bugzilla.

@berni44 berni44 requested a review from JackStouffer as a code owner January 17, 2021 18:14
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20539 minor std.conv.to: internal overload conflict for enums with base types that have a catch-all opEquals overload (?)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7749"

Copy link
Collaborator

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just fix the nit below.

std/conv.d Outdated Show resolved Hide resolved
with base types that have a catch-all opEquals overload (?)
@dlang-bot dlang-bot merged commit 54f224a into dlang:master Jan 19, 2021
@berni44 berni44 deleted the issue20539 branch February 13, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants