Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 15136 - If we want toStringz to be fully correct, it needs … #7806

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

aG0aep6G
Copy link
Contributor

…to stop checking for '\0'

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15136 normal If we want toStringz to be fully correct, it needs to stop checking for '\0'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7806"

Copy link
Member

@schveiguy schveiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing to think about, if there is already a null character on a string value (within the bounds), then reallocation isn't going to do anything.

@PetarKirov
Copy link
Member

Some related discussion regarding this optimization:
https://forum.dlang.org/post/ildzweoczmwvflodfadk@forum.dlang.org

std/string.d Outdated
@@ -395,6 +378,27 @@ pure nothrow @system unittest
const string test2 = "";
p = toStringz(test2);
assert(*p == 0);

assert(toStringz([]) is "".ptr);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be failing on CircleCi

Apparently, two empty string literals can have different pointers.
@RazvanN7 RazvanN7 merged commit 96dc6ff into dlang:master Feb 22, 2021
@aG0aep6G aG0aep6G deleted the 15136 branch March 2, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants