Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21663 - std.concurrency.receiveOnly doesn't work with tuples #7813

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Feb 25, 2021

No description provided.

@pbackus pbackus requested a review from MartinNowak as a code owner February 25, 2021 17:46
@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 25, 2021

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21663 regression std.concurrency.receiveOnly doesn't work with tuples

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7813"

@pbackus pbackus changed the base branch from master to stable February 25, 2021 17:50
@pbackus
Copy link
Contributor Author

pbackus commented Feb 25, 2021

CI is failing because this targets stable and therefore doesn't have the changes from #7744.

@RazvanN7
Copy link
Collaborator

RazvanN7 commented Mar 1, 2021

This is weird. The latest version of stable [1] does not include this test. It seems like the CI is using a prior version of stable :-?

[1] https://github.com/dlang/phobos/blob/stable/std/conv.d#L5710

@pbackus
Copy link
Contributor Author

pbackus commented Mar 1, 2021

Looks like I just missed the latest update to stable (2a2a0b4). I've rebased again, which should fix it.

@dlang-bot dlang-bot merged commit 6e6e024 into dlang:stable Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants