Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casting std.BigInts to built-in floating point types not allowed in @safe code without -preview=dip1000 #7877

Merged
merged 1 commit into from Mar 18, 2021

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Mar 18, 2021

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 18, 2021

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
21721 normal casting std.BigInts to built-in floating point types not allowed in @safe code without -preview=dip1000

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7877"

@thewilsonator
Copy link
Contributor

which lines specifically are unsafe without dip1000? @trusted on a large function is not a good idea.

@n8sh n8sh changed the base branch from master to stable March 18, 2021 06:38
…s not allowed in `@safe` code without -preview=dip1000
@n8sh
Copy link
Member Author

n8sh commented Mar 18, 2021

Changed to use @trusted lambda pattern.

@dlang-bot dlang-bot merged commit 40b34d3 into dlang:stable Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants