Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix second part of Issue 21722 - toString(sink, string format) does not work with non-"%s" strings #7966

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Apr 14, 2021

It took me a whole month to understand a comment from @Geod24 in #7870. Sorry for being so ignorant. This is essentially the same fix, but with -preview=in, so I did not create a new issue; hope this is correct - the testers currently don't check with -preview=in as far as I know. I did that locally though. (And I still based on master, due to the heavy changes to std.format in the last weeks; again I hope that's ok.)

Finally, I wonder, why there is no customPutWriterFormatString. Does anybody know a reason? Or was it just forgotten?

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21722 major toString(sink, string format) does not work with non-"%s" strings

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7966"

@RazvanN7 RazvanN7 added Merge:72h no objection -> merge The PR will be merged if there are no objections raised. Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Apr 16, 2021
@dlang-bot dlang-bot merged commit fc8849a into dlang:master Apr 19, 2021
@berni44 berni44 deleted the issue_21722b branch April 28, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants