fix Issue 21834 - std.numeric.gcd can't handle negative values #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7974" |
ibuclaw
force-pushed
the
issue21834
branch
3 times, most recently
from
78398a8 to
af58e8c
Compare
thewilsonator
approved these changes
Apr 17, 2021
|
Eh... you can't mix signed and unsigned types as parameters for |
ibuclaw
force-pushed
the
issue21834
branch
2 times, most recently
from
98e4a58 to
56bdd28
Compare
|
please merge this when you're satisfied with it. |
If you're happy with the new signature... On reviewing this morning, I'd feel more sure if there was a mixed types test added to verify it is handled correctly. I'll have a small dig around the git history as well to add a few more comments, as why DigitalMars uses Euclid's algorithm is beyond me. |
berni44
reviewed
Apr 17, 2021
|
@thewilsonator @berni44 - rebased on top of other PR refactoring/fixes and added more tests. |
berni44
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty lame restriction. Parameters should always be transformed to an unsigned value.