Fix Issue 21853 - std.format: formatting real.max in CTFE fails #8001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this bug in #7862: The reason is, that
log2rounds up (due to floating points not precise enough) when the result is very close to an integer and thus the appendedfloorwon't work anymore.I fixed this by checking for
max_exp - 1explicitly and for all others by detecting, that the first (implied) bit of the mantissa is 0 and not 1 as it should be. In this case the result is corrected accordingly.PS: I would really appreciate if we could have a
cast(ulong[2])for reals in CTFE, similar to the available casts forfloatanddouble. This would safe us from such trouble.