Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21853 - std.format: formatting real.max in CTFE fails #8001

Closed
wants to merge 1 commit into from

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Apr 23, 2021

I introduced this bug in #7862: The reason is, that log2 rounds up (due to floating points not precise enough) when the result is very close to an integer and thus the appended floor won't work anymore.

I fixed this by checking for max_exp - 1 explicitly and for all others by detecting, that the first (implied) bit of the mantissa is 0 and not 1 as it should be. In this case the result is corrected accordingly.

PS: I would really appreciate if we could have a cast(ulong[2]) for reals in CTFE, similar to the available casts for float and double. This would safe us from such trouble.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21853 normal std.format: formatting real.max in CTFE fails

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8001"

@berni44
Copy link
Contributor Author

berni44 commented Apr 23, 2021

Forgot to check for x87 reals in the unittest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants