Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20756: Handle interface argument in AllImplicitConversionTargets. #8016

Conversation

FeepingCreature
Copy link
Contributor

@FeepingCreature FeepingCreature commented Apr 27, 2021

Replaces #7453

ping @berni44 , @RazvanN7

This should probably go in 2.097 so we don't release an incomplete version of ImplicitConversionTargets a second time. Does that need master or stable?

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20756 enhancement ImplicitConversionTargets ignores interface inheritance

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8016"

@RazvanN7
Copy link
Collaborator

Since #7881 targeted master, this should also target master.

ImplicitConversionTargets was deprecated.

@berni44
Copy link
Contributor

berni44 commented Apr 27, 2021

Hey great! I didn't touch the non built-ins, because I know too little about this.

@FeepingCreature
Copy link
Contributor Author

FeepingCreature commented Apr 27, 2021

As far as I can see, the buildkite failure is spurious: there's no actual error, just deprecations. The build tries to set it to succeed despite deprecations, but it doesn't work.

@RazvanN7
Copy link
Collaborator

RazvanN7 commented Apr 27, 2021

Indeed, for some reason, the build hangs at some point for no apparent reason.

I restarted buildkite and seems to be green now.

@dlang-bot dlang-bot merged commit 2fac584 into dlang:master Apr 27, 2021
@FeepingCreature FeepingCreature deleted the fix/issue-20756-allimplicitconversiontargets-interface-parent branch April 27, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants