Fix for issue 6113. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really should have made those static constructors shared in the first place, since immutable class and global variables are implicitly shared.
|
Thanks for going through the review process. |
|
I'm OKing this but for some reason I can't merge it automatically. Could you please push the code yourself? Thanks! |
|
There's a merge conflict in changelog.dd. That's why it won't merge automatically. I'll merge it in shortly. |
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
Fixed: win32.mak's tag rules were out-of-date and failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually simple enough that I'm halfway tempted to just commit the changes. UTC._utc and LocalTime._localTime are immutable class variables which are the singletons for their respective classes. However, the static constructor which initialize them are not currently shared like they should be. Since immutable static variables and immutable global variables are implicitly shared, it's not a good idea to initialize them in non-shared static constructors and in fact should probably be an error (e.g. http://d.puremagic.com/issues/show_bug.cgi?id=4923 and http://d.puremagic.com/issues/show_bug.cgi?id=6114 ).