Conv missing doc #811

Merged
merged 1 commit into from Sep 29, 2012

Conversation

Projects
None yet
3 participants
@monarchdodra
Collaborator

monarchdodra commented Sep 21, 2012

There is a huge bloc of documentation regarding "to", that doesn't show up in http://dlang.org/phobos/std_conv.html

This pull request makes it appear.

@9rnsr

This comment has been minimized.

Show comment Hide comment
@9rnsr

9rnsr Sep 21, 2012

Member

I think almost of the ddoc is still correct, but following example code does not work with current std.conv.to.

int[string][double[int[]]] a;
auto b = to!(short[wstring][string[double[]]])(a);

I think this is a bug of std.conv.to...

Member

9rnsr commented Sep 21, 2012

I think almost of the ddoc is still correct, but following example code does not work with current std.conv.to.

int[string][double[int[]]] a;
auto b = to!(short[wstring][string[double[]]])(a);

I think this is a bug of std.conv.to...

@9rnsr

This comment has been minimized.

Show comment Hide comment
@9rnsr

9rnsr Sep 21, 2012

Member

And removing ddoc was introduced the commit ca2a767, I don't why.
@andralex , I think you should check this pull request.

Member

9rnsr commented Sep 21, 2012

And removing ddoc was introduced the commit ca2a767, I don't why.
@andralex , I think you should check this pull request.

@monarchdodra

This comment has been minimized.

Show comment Hide comment
@monarchdodra

monarchdodra Sep 21, 2012

Collaborator

The commit in question added some stuff, but regarding the current pull, it merely changed a
/***************************************************************
into
/* **************************************************************

It is a bit hard to see, since the diff marks at as removed line 108, then added line 366.

It feels like a typo, but at the same time, it is not the kind of typo you'd do accidentally.

I can confirm that:

int[string][double[int[]]] a;
auto b = to!(short[wstring][string[double[]]])(a);

Doesn't work.

What should I do about that?

  1. Nothing: Just leave it in and don't comment?
  2. Mark as bug:currently not yet working?
  3. Change the example to something that does work? (Nah...)

Tempted to do nothing and leave as is, IMO.

Collaborator

monarchdodra commented Sep 21, 2012

The commit in question added some stuff, but regarding the current pull, it merely changed a
/***************************************************************
into
/* **************************************************************

It is a bit hard to see, since the diff marks at as removed line 108, then added line 366.

It feels like a typo, but at the same time, it is not the kind of typo you'd do accidentally.

I can confirm that:

int[string][double[int[]]] a;
auto b = to!(short[wstring][string[double[]]])(a);

Doesn't work.

What should I do about that?

  1. Nothing: Just leave it in and don't comment?
  2. Mark as bug:currently not yet working?
  3. Change the example to something that does work? (Nah...)

Tempted to do nothing and leave as is, IMO.

@9rnsr

This comment has been minimized.

Show comment Hide comment
@9rnsr

9rnsr Sep 21, 2012

Member

It feels like a typo, but at the same time, it is not the kind of typo you'd do accidentally.

I agree, therefoe I'd like to answer to @andralex .

What should I do about that?

  1. Move out the relevant section to un-ddoc comment in this pull
/**
aaa

xxx
*/
template to(T) { ... }

to

/**
aaa
*/ /*
xxx
*/
template to(T) { ... }
  1. file the std.conv.to bug to bugzilla.
Member

9rnsr commented Sep 21, 2012

It feels like a typo, but at the same time, it is not the kind of typo you'd do accidentally.

I agree, therefoe I'd like to answer to @andralex .

What should I do about that?

  1. Move out the relevant section to un-ddoc comment in this pull
/**
aaa

xxx
*/
template to(T) { ... }

to

/**
aaa
*/ /*
xxx
*/
template to(T) { ... }
  1. file the std.conv.to bug to bugzilla.
@monarchdodra

This comment has been minimized.

Show comment Hide comment
@monarchdodra

monarchdodra Sep 21, 2012

Collaborator

Filed the bug: http://d.puremagic.com/issues/show_bug.cgi?id=8705

I'll wait for feedback from @andralex before adding any change.

Collaborator

monarchdodra commented Sep 21, 2012

Filed the bug: http://d.puremagic.com/issues/show_bug.cgi?id=8705

I'll wait for feedback from @andralex before adding any change.

@andralex

This comment has been minimized.

Show comment Hide comment
@andralex

andralex Sep 29, 2012

Owner

As far as I remember I disabled doc generation for a mundane reason (finding a missing paren in the documentation or something) so this diff is good, thanks. I think it would be great to also fix the bug revealed by it before 2.061. @monarchdodra, would you like to do the honors? Thanks!

Owner

andralex commented Sep 29, 2012

As far as I remember I disabled doc generation for a mundane reason (finding a missing paren in the documentation or something) so this diff is good, thanks. I think it would be great to also fix the bug revealed by it before 2.061. @monarchdodra, would you like to do the honors? Thanks!

andralex added a commit that referenced this pull request Sep 29, 2012

@andralex andralex merged commit f41f43d into dlang:master Sep 29, 2012

1 check passed

default Pass: 9
Details
@monarchdodra

This comment has been minimized.

Show comment Hide comment
@monarchdodra

monarchdodra Sep 29, 2012

Collaborator

I looked a bit harder at the issue. It is not solveable without first fixing a new issue:

http://d.puremagic.com/issues/show_bug.cgi?id=8737

I think this is a deeper dmd issue. Could you someone take a peak at it? I'm not sure where to go from here.

Collaborator

monarchdodra commented Sep 29, 2012

I looked a bit harder at the issue. It is not solveable without first fixing a new issue:

http://d.puremagic.com/issues/show_bug.cgi?id=8737

I think this is a deeper dmd issue. Could you someone take a peak at it? I'm not sure where to go from here.

@monarchdodra

This comment has been minimized.

Show comment Hide comment
@monarchdodra

monarchdodra Sep 29, 2012

Collaborator

I think this is a deeper dmd issue. Could you someone take a peak at it? I'm not sure where to go from here.

I think I got it actually.

EDIT: Oh yeah. Got it! Will make the fix tomorrow.

Collaborator

monarchdodra commented Sep 29, 2012

I think this is a deeper dmd issue. Could you someone take a peak at it? I'm not sure where to go from here.

I think I got it actually.

EDIT: Oh yeah. Got it! Will make the fix tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment