-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 22511 - Add explicit copy ctor for Nullable #8316
Conversation
|
Thanks for your pull request and interest in making D better, @omerfirmak! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8316" |
3f610cf to
10d13ba
Compare
cf640f4 to
30cbf55
Compare
|
Could do with testing that copy ctor for payload is actually getting called. |
8f743b2 to
4870fc5
Compare
Done |
|
I am trying to fix the fundamental issue. Maybe this will not be necessary once dlang/dmd#13306 gets in. |
This is another issue tho, isnt it? #8315 was the workaround for 22510. |
|
Ah scratch that, I didn't read carefully and I thought that this is another workaround for the cpctor issue. |
No description provided.