Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 22511 - Add explicit copy ctor for Nullable #8316

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

omerfirmak
Copy link
Contributor

No description provided.

@omerfirmak omerfirmak requested a review from MetaLang as a code owner November 14, 2021 14:39
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @omerfirmak! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22511 enhancement Nullable is not copyable when templated type has elaborate copy ctor

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8316"

@radcapricorn
Copy link
Contributor

Could do with testing that copy ctor for payload is actually getting called.

@omerfirmak omerfirmak force-pushed the fix22511 branch 2 times, most recently from 8f743b2 to 4870fc5 Compare November 15, 2021 06:53
@omerfirmak
Copy link
Contributor Author

Could do with testing that copy ctor for payload is actually getting called.

Done

@RazvanN7
Copy link
Collaborator

I am trying to fix the fundamental issue. Maybe this will not be necessary once dlang/dmd#13306 gets in.

@omerfirmak
Copy link
Contributor Author

I am trying to fix the fundamental issue. Maybe this will not be necessary once dlang/dmd#13306 gets in.

This is another issue tho, isnt it? #8315 was the workaround for 22510.

@RazvanN7
Copy link
Collaborator

Ah scratch that, I didn't read carefully and I thought that this is another workaround for the cpctor issue.

@RazvanN7 RazvanN7 merged commit c0a8bd6 into dlang:master Nov 15, 2021
dlang-bot added a commit that referenced this pull request Nov 15, 2021
Merge PR #8315 & #8316 in to `stable`

Signed-off-by: Razvan Nitu <RazvanN7@users.noreply.github.com>
Merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants