Fix 17416 - Add REUSEPORT to std.socket #8389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue also mentions the Druntime bindings, which have been added a few years ago, however this was missing from std.socket. This implementation provides SO_REUSEPORT on Windows as well, despite it being equivalent to SO_REUSEADDR, to simplify client code.
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8389" |
maxhaton
approved these changes
Feb 20, 2022
|
Thanks. What about the other POSIX OSes? Would be nice to have a reference link for the Windows situation. |
|
@Geod24 Tiny bump in case you missed the comment above. |
|
@Geod24 Can you rebase and update the documentation comment? |
|
ping @Geod24 |
LightBender
added
the
Review:Salvage
|
I’ve picked this one up and added a reference link; see #9082 for my adaption. |
|
#9082 was merged. I think this one can get closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue also mentions the Druntime bindings, which have been added a few years ago,
however this was missing from std.socket. This implementation provides SO_REUSEPORT on
Windows as well, despite it being equivalent to SO_REUSEADDR, to simplify client code.