Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22838 - BitArray.count reads beyond data #8400

Closed
wants to merge 23 commits into from

Conversation

JohanEngelen
Copy link
Contributor

This fixes issue 22838
https://issues.dlang.org/show_bug.cgi?id=22838

All hail AddressSanitizer! ;-)

dkorpel and others added 23 commits February 14, 2022 23:34
etc.c.odbc: Update removal dates for ODBC deprecations
std.zip: Remove declarations with expired deprecations
Fix issue 22798.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
This makes it clearer why SumType.opAssign must sometimes be @System.
getopt: mark defaultGetoptPrinter as @safe
isSumType!T now evaluates to true instead of false when T is a templated
struct type that implicitly converts to a SumType via alias this.
Since ReadFile requires an offset buffer and the maximum size is size_t.max, we
should offset with size_t to avoid overflow on dereferencing.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
...fails to mention different behavior depending on
hasElaborateCopyConstructor

The new wording is based on the documentation for core.lifetime.move.
merge stable

Signed-off-by: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
@JohanEngelen JohanEngelen requested a review from andralex as a code owner March 2, 2022 23:57
@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 2, 2022

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18036 normal Documentation of moveFront() fails to mention different behavior depending on hasElaborateCopyConstructor
21975 normal is expression ignores implicit conversion of struct via alias this when pattern matching
22771 normal BigInt divMod can return "-0" (negative zero)
22791 normal std\socket.d(790) Heisenbug random failure
22798 enhancement defaultGetoptPrinter should be @safe
22838 critical std.bitmanip.BitArray.count() reads beyond data when data size is integer size_t multiple

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8400"

@JohanEngelen JohanEngelen changed the base branch from master to stable March 2, 2022 23:58
@JohanEngelen
Copy link
Contributor Author

Closing, resubmitting on stable

@JohanEngelen JohanEngelen deleted the JohanEngelen-patch-1 branch March 2, 2022 23:58
@JohanEngelen
Copy link
Contributor Author

#8401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants