-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 22838 - BitArray.count reads beyond data #8400
Conversation
etc.c.odbc: Update removal dates for ODBC deprecations
std.zip: Remove declarations with expired deprecations
Fix issue 22798. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
This makes it clearer why SumType.opAssign must sometimes be @System.
getopt: mark defaultGetoptPrinter as @safe
isSumType!T now evaluates to true instead of false when T is a templated struct type that implicitly converts to a SumType via alias this.
Since ReadFile requires an offset buffer and the maximum size is size_t.max, we should offset with size_t to avoid overflow on dereferencing. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
...fails to mention different behavior depending on hasElaborateCopyConstructor The new wording is based on the documentation for core.lifetime.move.
merge stable Signed-off-by: Nicholas Wilson <thewilsonator@users.noreply.github.com> Merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This reverts commit 2de6834.
This fixes issue 22838 https://issues.dlang.org/show_bug.cgi?id=22838
|
Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + phobos#8400" |
|
Closing, resubmitting on |
This fixes issue 22838
https://issues.dlang.org/show_bug.cgi?id=22838
All hail AddressSanitizer! ;-)