Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22946 - Mark WindowsException ctor as nothrow #8421

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Mar 27, 2022

Catch possible exceptions arising from e.g. UTF decoding and ensure that the message buffer doesn't contain partial output from a failed step.

The logic is seperated into a dedicated method because it's required for another bugfix.


Extracted from #8420.

CC @CyberShadow.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22946 normal WindowsException ctor is not nothrow

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8421"

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

std/windows/syserror.d Outdated Show resolved Hide resolved
Catch possible exceptions arising from e.g. UTF decoding and ensure
that the message buffer doesn't contain partial output from a failed
step.

The logic is seperated into a dedicated method because it's required
for another bugfix.
@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Mar 27, 2022

(Rebased to hopefully fix buildkite ...)

@dlang-bot dlang-bot merged commit 167b1af into dlang:master Mar 27, 2022
@MoonlightSentinel MoonlightSentinel deleted the nothrow-windows-exception branch March 27, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants