Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22213 - Base64: Missing @nogc attribute on encodeLength #8430

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 13, 2022

Improve attributes of std.base64

@dkorpel dkorpel requested a review from andralex as a code owner April 13, 2022 14:07
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22213 normal Base64: Missing `@nogc` attribute on encodeLength

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8430"

@RazvanN7 RazvanN7 merged commit 31a2744 into dlang:master Apr 15, 2022
@dkorpel dkorpel deleted the base64-attr branch April 15, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants