-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 22637 - std.conv to!double and parse!double dont throw on under/overflow
#8502
Conversation
|
Thanks for your pull request and interest in making D better, @GrimMaple! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8502" |
|
technically, this should target stable. But it's probably not a huge issue that needs to get in next release. |
Err, you've got hours before the next point release is tagged, otherwise you're going to have to wait a couple months for the next release. |
…on under/overflow This happened because `parse` enforced on real. And provided number actually fits real. Changed to enforce on `Target` type instead
|
Don't worry about putting it in stable. Even though it's a bug fix, it doesn't affect currently-compiling code. |
|
@kinke any objection? I'll tag with the 72 hour merge. Feel free to merge early. |
This happened because
parseenforced on real.And provided number actually fits real.
Changed to enforce on
Targettype instead