FIx issue 7992 #852
Merged
FIx issue 7992 #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| debug(std_algorithm) scope(success) | ||
| writeln("unittest @", __FILE__, ":", __LINE__, " done."); | ||
|
|
||
| struct CustomString { |
There was a problem hiding this comment.
Please do not put braces on the same line as other stuff like this. The lines below are okay, because the whole thing is on one line, but other than cases like that, braces need to go on their own line.
|
Fixed coding style. |
|
Rebased. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is caused by haystackTooShort() always returning false when both the haystack and the needle have a length property defined. This causes the searching loop to call popFront() on an empty haystack.