Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21000 - allow use of std{in,out,err} with -preview=noshared… #8562

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

atilaneves
Copy link
Contributor

…access

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @atilaneves! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21000 enhancement -preview=nosharedaccess precludes use of stdin,stdout,stderr

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8562"

@atilaneves
Copy link
Contributor Author

I don't know how to prove this works other than to say I tried it manually. I can't add the preview flag since this particular issue was covering up many more.

@CyberShadow
Copy link
Member

There are some stand-alone tests in the test directory, maybe that would be a good place?

@RazvanN7
Copy link
Collaborator

ping @atilaneves

@RazvanN7
Copy link
Collaborator

There are 2 ways we can go about this:

(1) add a test in the tests directory and compile it with -preview=nosharedaccess; this seems like an unpopular path since there are only 3 tests in that directory.

(2) continue fixing this up and put this test in a unittest once we are able to compile phobos with -preview=nosharedaccess`; I am inclined to go down this route as long as you are pursuing it @atilaneves .

Let me know what you prefer.

@atilaneves
Copy link
Contributor Author

For now I'd prefer to put it in the test directory, but I don't see anything in the Makefile that runs those except for explicitly running the betterC tests.

TBH I think that this is overkill given that this is necessary and I'd be in favour of merging as-is.

@RazvanN7 RazvanN7 merged commit 445a2e9 into dlang:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants