-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 23333: Make DList range access @nogc #8567
Conversation
|
Thanks for your pull request and interest in making D better, @AndrejMitrovic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8567" |
std/container/dlist.d
Outdated
|
|
||
| () @nogc { | ||
| auto rn = nl[]; | ||
| auto el = nl.front; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably also test .back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this test is even required. I mean, if the code compiles with @nogc: that means that the functions that were annotated have passed compilation. I would simply drop this test.
|
@AndrejMitrovic can you delete the test so that we can merge this? |
7928ed9 to
63d28de
Compare
|
@RazvanN7 done. |
Unless I'm missing something this looked like an easy win to me.
Haven't done the full test-suite yet, and I am super out of date with what the newest dev/testing methodology is. Let me know if I've missed anything~