Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 23333: Make DList range access @nogc #8567

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

AndrejMitrovic
Copy link
Contributor

Unless I'm missing something this looked like an easy win to me.

Haven't done the full test-suite yet, and I am super out of date with what the newest dev/testing methodology is. Let me know if I've missed anything~

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @AndrejMitrovic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23333 enhancement DList range can be @nogc

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8567"


() @nogc {
auto rn = nl[];
auto el = nl.front;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably also test .back

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this test is even required. I mean, if the code compiles with @nogc: that means that the functions that were annotated have passed compilation. I would simply drop this test.

@maxhaton maxhaton requested a review from pbackus September 14, 2022 01:19
@RazvanN7
Copy link
Collaborator

@AndrejMitrovic can you delete the test so that we can merge this?

@AndrejMitrovic
Copy link
Contributor Author

@RazvanN7 done.

@dlang-bot dlang-bot merged commit 92a9d60 into dlang:master Sep 15, 2022
@AndrejMitrovic AndrejMitrovic deleted the nogc-dlist-range branch September 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants