Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23350 - Nondeterministic test failure in std.concurrency #8579

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Sep 20, 2022

Previously, a TOCTOU bug in threadInfo could result in a null dereference if 'scheduler' was changed to null between the evaluation of the 'if' condition and the call to scheduler.threadInfo.

Previously, a TOCTOU bug in threadInfo could result in a null
dereference if 'scheduler' was changed to null between the evaluation of
the 'if' condition and the call to scheduler.threadInfo.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23350 normal Nondeterministic test failure in std.concurrency

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8579"

@pbackus
Copy link
Contributor Author

pbackus commented Sep 20, 2022

Technically this is still a data race unless all accesses to scheduler are made atomic, but it seems like that's something we can get away with on the platforms we currently test on, so probably ok to put off fixing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants