Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permutations into forward range. #8580

Merged
merged 4 commits into from Sep 26, 2022
Merged

Make permutations into forward range. #8580

merged 4 commits into from Sep 26, 2022

Conversation

jamesragray
Copy link

Since there was nothing preventing permutations from being a forward range, I have added a save method to make it into one. This is related to Issue 18975 - permutations.array creates an array of the original type without the permutations but doesn't fix it.

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 21, 2022

Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23362 normal Permutations should be a forward range

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8580"

std/algorithm/iteration.d Outdated Show resolved Hide resolved
@RazvanN7
Copy link
Collaborator

We should get this in as the spec specifically states that the return permutations returns a forward range. This should be filed as a bug.

Copy link
Collaborator

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a draft?

std/algorithm/iteration.d Outdated Show resolved Hide resolved
Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlang-bot dlang-bot merged commit b026e49 into dlang:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants