Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve std.experimental.allocator docs #8604

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 16, 2022

Add missing LREFs in top table.
Use RUNNABLE_EXAMPLE for synopsis.

Add missing LREFs in top table.
Use RUNNABLE_EXAMPLE.
@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 16, 2022

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19737 enhancement [std.experimental.allocator] link table in docs has missing symbols

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8604"

@ntrel
Copy link
Contributor Author

ntrel commented Oct 16, 2022

auto-tester failure must be unrelated (only doc changes here).

****** FAIL debug32 std.datetime.stopwatch
core.exception.AssertError@std/datetime/stopwatch.d(169): unittest failure

@ntrel ntrel marked this pull request as draft October 16, 2022 17:06
@ntrel ntrel marked this pull request as ready for review October 16, 2022 17:06
@dkorpel dkorpel merged commit a3536c6 into dlang:master Oct 24, 2022
@ntrel ntrel deleted the allocator-docs branch October 24, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants