fixes #23507 sockets are blocking by default, this needs to reflect that

[adamdruppe]

This is remarkable to me - git blame says this was there in the initial commit to git in 2007, meaning it goes back to prehistory (though I could probably download some ancient phobos and check there, but i suspect it has been there the whole time), but I'm almost certain this is wrong.

Windows sockets are blocking by default. The Phobos docs, the constructor for Socket, states that it "creates a blocking socket". The behavior is blocking. But this property defaults to false.... and a new commit to my code happened to use it, assuming it had correct info, causing a regression for me!

But, as far as I can tell, this should have been true by default the whole time.

[dlang-bot]

Thanks for your pull request and interest in making D better, @adamdruppe! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23507	normal	Socket.blocking property incorrect on new Socket on Windows

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8630"

[thewilsonator]

I feel that this should have a changelog entry so there is documentation of this.

[adamdruppe]

i just filed a bugzilla https://issues.dlang.org/show_bug.cgi?id=23507

[thewilsonator]

Need to update the commit title, otherwise this looks good to go. I don't think a test is really necessary, but I won't say no to one.

[adamdruppe]

I don't think a test can be meaningful here unless it actually maybe asked the operating system to confirm the state which didn't used to be possible. I think it is now but it is a bit of a hassle.

[skoppe]

What if you create a Socket by passing in an existing socket_t? https://github.com/adamdruppe/phobos/blob/6fa48e418e8bf134dd4cf07bbf3900eb57305788/std/socket.d#L2733

It might be blocking, non-blocking, who knows? Well, on linux we can check, but on windows there doesn't seem to be an api for it (says 5min googling).

Still, this MR should go in, because they do start out blocking.

[adamdruppe]

Yeah, we should probably at least document that... or make it a required argument to that ctor but that's a hassle.

i kinda like std.socket but i also kinda hate it too lol it is useful but has a few rough edges