Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Fix Issue 22745 - std.parallelism.parallel fails to process empty range on a single CPU #8633

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Nov 30, 2022

Targeting stable because it's a pretty embarrassing bug and was just encountered at work, in a VM with a single CPU core.

@kinke kinke requested a review from andralex as a code owner November 30, 2022 21:33
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22745 normal std.parallelism.parallel fails to process empty range on a single CPU

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8633"

@kinke
Copy link
Contributor Author

kinke commented Nov 30, 2022

@CyberShadow: Looks like the DAutoTest job is broken against stable.

git clone -b v2.101.0 --depth=1 https://github.com/dlang/druntime .generated/druntime-2.101.0
Cloning into '.generated/druntime-2.101.0'...
warning: Could not find remote branch v2.101.0 to clone.
fatal: Remote branch v2.101.0 not found in upstream origin
posix.mak:580: recipe for target '.generated/druntime-2.101.0' failed
make: *** [.generated/druntime-2.101.0] Error 128

@CyberShadow
Copy link
Member

CyberShadow commented Nov 30, 2022

DAutoTest just runs the makefiles, it contains almost no logic like that on its own.

I think dlang/dlang.org#3455 should fix that once it's merged back into stable. CC @ibuclaw

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Geod24 Geod24 merged commit 5645d87 into dlang:stable Dec 1, 2022
@kinke kinke deleted the fix22745 branch December 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants