Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 23540 - std.uni loadProperty aliases for C are incorrect #8652

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

rikkimax
Copy link
Contributor

This is a bit of unfortunate breakage, but it is what it is.

It shouldn't come up again and doesn't need a test as it should never have diverged from the standard like this.

There is a mitigation code in the changelog & I'll do an announcement to give people time to mitigate this and the tables being updated.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23540 normal std.uni loadProperty aliases for C are incorrect

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8652"

@rikkimax
Copy link
Contributor Author

Okay, what am I doing wrong with the changelog?

@rikkimax
Copy link
Contributor Author

@RazvanN7 helppppp please!

@RazvanN7 RazvanN7 merged commit 313715c into dlang:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants