Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 23668: TimSort must avoid default initialization if the type being sorted has it disabled. #8676

Merged

Conversation

FeepingCreature
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 3, 2023

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23668 minor Can't stable sort structs with disabled default constructor.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8676"

@FeepingCreature FeepingCreature force-pushed the fix/issue-23668-stable-sort branch from 1fccc7d to fb171d2 Compare February 3, 2023 13:43
@FeepingCreature FeepingCreature changed the base branch from master to stable February 3, 2023 13:43
@FeepingCreature FeepingCreature force-pushed the fix/issue-23668-stable-sort branch from fb171d2 to 7e0afec Compare February 3, 2023 13:44
@FeepingCreature FeepingCreature force-pushed the fix/issue-23668-stable-sort branch from 7e0afec to 01b99cb Compare February 3, 2023 13:58
@dlang-bot dlang-bot merged commit c06e317 into dlang:stable Feb 4, 2023
@FeepingCreature FeepingCreature deleted the fix/issue-23668-stable-sort branch February 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants