-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better document the use of Heaps with Dynamic Array as Store #8677
Conversation
Fix issue 18333: binaryHeap documentation inadequately describes slice store invalidation
|
Thanks for your pull request and interest in making D better, @MathewColin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8677" |
Fix issue 18333: binaryHeap documentation inadequately describes slice store invalidation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move the new test after the normal example? It's confusing to start with examples of unusual behavior before examples of usual behavior.
std/container/binaryheap.d
Outdated
| int[] a = [ 4, 1, 3, 2, 16, 9, 10, 14, 8, 7 ]; | ||
| auto h = heapify(a); | ||
|
|
||
| /* Internal representation of Binary Heap tree */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /* Internal representation of Binary Heap tree */ | |
| // Internal representation of Binary Heap tree |
I suggest using the same comment style as the other example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will move the example and also change the comment style.
Fix issue 18333: binaryHeap documentation inadequately describes slice store invalidation
https://issues.dlang.org/show_bug.cgi?id=18333