Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 23668: TimSort must avoid default initialization if the type being sorted has it disabled. #8683

Merged
merged 2 commits into from Feb 13, 2023
Merged

Fix issue 23668: TimSort must avoid default initialization if the type being sorted has it disabled. #8683

merged 2 commits into from Feb 13, 2023

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 13, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23668 minor Can't stable sort structs with disabled default constructor.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8683"

@dlang-bot dlang-bot merged commit 73ba453 into dlang:master Feb 13, 2023
@ibuclaw ibuclaw deleted the merge_stable branch February 13, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@JackStouffer JackStouffer Awaiting requested review from JackStouffer JackStouffer is a code owner

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

@PetarKirov PetarKirov Awaiting requested review from PetarKirov PetarKirov is a code owner

Assignees
No one assigned
Labels
auto-merge Bug Fix stable -> master
Projects
None yet
Milestone
No milestone
4 participants
@ibuclaw @dlang-bot @thewilsonator @FeepingCreature