Fix Issue 23706 - Do not escape POSIX shell parameters unless necessary #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @CyberShadow! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8684" |
thewilsonator
approved these changes
Feb 14, 2023
Hey, we actually got tests for this! 😄 |
CyberShadow
force-pushed
the
pull-20230214-141547
branch
2 times, most recently
from
b1e9a6f
to
bc6197a
Compare
CyberShadow
force-pushed
the
pull-20230214-141547
branch
from
bc6197a
to
ca16267
Compare
Batch files generally don't have trailing semicolons.
POSIX follow-up to Issue 13447 / 09a0b87.
CyberShadow
force-pushed
the
pull-20230214-141547
branch
from
ca16267
to
fdceb11
Compare
RazvanN7
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX follow-up to Issue 13447 / 09a0b87.