Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23706 - Do not escape POSIX shell parameters unless necessary #8684

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

CyberShadow
Copy link
Member

POSIX follow-up to Issue 13447 / 09a0b87.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @CyberShadow!

Bugzilla references

Auto-close Bugzilla Severity Description
23706 enhancement Do not escape POSIX shell parameters unless necessary

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8684"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mind the red CI though

@CyberShadow
Copy link
Member Author

LGTM, mind the red CI though

Hey, we actually got tests for this! 😄

@CyberShadow CyberShadow force-pushed the pull-20230214-141547 branch 2 times, most recently from b1e9a6f to bc6197a Compare February 14, 2023 14:33
@CyberShadow CyberShadow marked this pull request as draft February 14, 2023 14:40
@CyberShadow CyberShadow marked this pull request as ready for review February 14, 2023 14:55
@RazvanN7 RazvanN7 merged commit 98de7a5 into dlang:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants