Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.net.curl: add missing import to examples #8688

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Feb 17, 2023

Fixes issue 23724 - HTTP.onReceive example does not compile

Fixes issue 23724 - HTTP.onReceive example does not compile
@pbackus pbackus requested a review from CyberShadow as a code owner February 17, 2023 23:10
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23724 minor HTTP.onReceive example does not compile

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8688"

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would also change the to call to UFCS, I think today that is more idiomatic.

@dlang-bot dlang-bot merged commit ec947eb into dlang:master Feb 17, 2023
@pbackus pbackus deleted the fix-23724 branch February 17, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants