Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve std.regex build times by removing a formattedWrite call #8698

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

rikkimax
Copy link
Contributor

I don't know how much we can actually do to speed it up, but this is at least still a win at about ~100ms. That shouldn't change anything other than build times.

Tracking issue (does not close): https://issues.dlang.org/show_bug.cgi?id=23737

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 24, 2023

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8698"

@rikkimax rikkimax changed the base branch from master to stable February 24, 2023 13:25
@rikkimax
Copy link
Contributor Author

And now we learn why that formattedWrite was there.

std/regex/internal/parser.d(1015): Error: cannot append type wstring to type string
std/regex/internal/parser.d(1017): Error: cannot append type wstring to type string

@dkorpel dkorpel merged commit 000705a into dlang:stable Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants