Fixed an off-by-one error in mailbox size handling. #90

Merged
merged 2 commits into from Jun 15, 2011

Conversation

Projects
None yet
2 participants
@klickverbot
Member

klickverbot commented Jun 9, 2011

The List.put(ref List) overload previously didn't increment m_count for rhs.m_front itself, leading to an underflow of m_count when removing all the messages. I suppose this didn't surface so far because m_count isn't really used if no mailbox size limit is set.

Also, I renamed the private put() method to appendNode() to avoid confusion as it is not an overload to the other put functions semantically.

klickverbot added some commits Jun 9, 2011

Fixed an off-by-one error in mailbox size handling.
The List.put(ref List) overload previously didn't increment m_count for rhs.m_front itself, leading to an underflow of m_count when removing all the messages. I suppose this didn't surface so far because m_count isn't really relevant if no mailbox size limit is set.

Also, I renamed the private put() method to appendNode() to avoid confusion as it is not really an overload semantically.
@andralex

This comment has been minimized.

Show comment
Hide comment
@andralex

andralex Jun 9, 2011

Member

Ouch. Sean, looks good?

Member

andralex commented Jun 9, 2011

Ouch. Sean, looks good?

@klickverbot

This comment has been minimized.

Show comment
Hide comment
@klickverbot

klickverbot Jun 14, 2011

Member

This has also been added to Bugzilla independently in the meantime: http://d.puremagic.com/issues/show_bug.cgi?id=6155

Member

klickverbot commented Jun 14, 2011

This has also been added to Bugzilla independently in the meantime: http://d.puremagic.com/issues/show_bug.cgi?id=6155

andralex added a commit that referenced this pull request Jun 15, 2011

Merge pull request #90 from klickverbot/concurrency-off-by-one
Fixed an off-by-one error in mailbox size handling.

@andralex andralex merged commit 10243e8 into dlang:master Jun 15, 2011

kuettler pushed a commit to kuettler/phobos that referenced this pull request Feb 6, 2018

Merge pull request #90 from nomad-software/master
Fixed Issue 11635 - RDMD should let -op flag pass through.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment