Fix Bugzilla 24773: don't invoke destructors on uninitialized elements in stable sort #9049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @s-ludwig! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#9049" |
s-ludwig
force-pushed
the
issue24773_stablesort_destructor
branch
from
df307a1
to
3b15836
Compare
thewilsonator
approved these changes
Sep 20, 2024
s-ludwig
changed the title
s-ludwig
changed the title
s-ludwig
force-pushed
the
issue24773_stablesort_destructor
branch
from
3b15836
to
0915d7a
Compare
…s in stable sort Uses a regular initialized temporary array when sorting elements with an elaborate assignment to avoid undefined behavior when destructors, postblits or copy constructors are invoked during the array assignment.
s-ludwig
force-pushed
the
issue24773_stablesort_destructor
branch
from
0915d7a
to
cfd577b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a regular initialized temporary array when sorting elements with an elaborate assignment to avoid undefined behavior when destructors, postblits or copy constructors are invoked during the array assignment.