Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 17416 - Add REUSEPORT to std.socket #9082

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

0xEAB
Copy link
Contributor

@0xEAB 0xEAB commented Nov 4, 2024

#8389 plus a reference link as requested by @CyberShadow.
Text has been adjusted to provide further explanations.

Further reading: https://stackoverflow.com/a/14388707

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 4, 2024

Thanks for your pull request and interest in making D better, @0xEAB! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
17416 enhancement SocketOption.REUSEPORT not available on linux

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9082"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retitle the commit message "Fix bugzilla issue 17416 - Add REUSEPORT to std.socket"

The issue also mentions the Druntime bindings, which have been added a few years ago,
however this was missing from std.socket. This implementation provides SO_REUSEPORT on
Windows as well, despite it being equivalent to SO_REUSEADDR, to simplify client code.

Co-authored-by: Elias Batek <desisma@heidel.beer>
@dlang-bot dlang-bot merged commit 9aa794c into dlang:master Nov 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants