Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement more property syntax enforcement #968

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Member

9rnsr commented Nov 23, 2012

Requires: dmd/pull/1311

See commit message for more details.

Member

klickverbot commented Nov 23, 2012

We'd better drop @property from std.file.exists – requiring the function to be called as a string property is definitely weird, and entirely inconsistent with the rest of the file functions. Note that it was marked up with the attribute long before the currently discussed language changes…

Member

9rnsr commented Nov 27, 2012

Now dmd/pull/1311 is closed, then close this.

@9rnsr 9rnsr closed this Nov 27, 2012

@9rnsr 9rnsr referenced this pull request Nov 27, 2012

Merged

Tweak for properties #978

Member

9rnsr commented Nov 27, 2012

Opened spin-out pull #978 from here.

jmdavis and others added some commits Dec 2, 2012

@jmdavis jmdavis Merge pull request #978 from 9rnsr/tweak_properties
Tweak for properties
47e6293
@9rnsr 9rnsr Remove remain redundant parenthesis.
This change requires following two compiler fixes.
- Issue 9062 - AddrExp should distinguish the existence of property resolution.
e70d8d8
@9rnsr 9rnsr Except opDollar, we should not mark member functions for operator ove…
…rloading as properties.
6aa0c15
@9rnsr 9rnsr We should always call std.file.exists by UFCS.
std.file.exists is a module level property function that receives one argument.
With new property enforcement mechanism, we cannot call it with normal function syntax (has parenthesis).
1c618f3
@9rnsr 9rnsr Remove @property attribute from std.file.exists, instead of enforcing…
… UFCS property usage
51aaf81

@9rnsr 9rnsr reopened this Dec 3, 2012

Member

9rnsr commented Dec 3, 2012

Reopened. Most changes which had been unrelated to compiler fix were separately merged by #978.

@9rnsr 9rnsr referenced this pull request in dlang/dmd Dec 3, 2012

Closed

Implement more property syntax enforcement #1311

Owner

andralex commented Dec 9, 2012

This pull makes sense, but it's time to overhaul the entire approach to properties. Let's hold back on it for a while.

@9rnsr 9rnsr closed this Jan 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment