Skip to content

allow to configure DFLAGS and WARNINGS#301

Merged
wilzbach merged 1 commit into
dlang:masterfrom
MartinNowak:warnings
Jan 27, 2018
Merged

allow to configure DFLAGS and WARNINGS#301
wilzbach merged 1 commit into
dlang:masterfrom
MartinNowak:warnings

Conversation

@MartinNowak
Copy link
Copy Markdown
Member

  • e.g. to test dlang/tools without erroring on deprecations (ci.dlang.org)
  • use override DFLAGS += for non-configurable target specific flags

- e.g. to test dlang/tools without erroring on deprecations (ci.dlang.org)
- use `override DFLAGS +=` for non-configurable target specific flags
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Copy Markdown
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but we probably want to use -de on the auto-tester as it leaves a bad imagine if our core tools have deprecation messages and if they aren't fixed by the one who introduces the deprecation, no one will care.

@wilzbach wilzbach merged commit 6840d41 into dlang:master Jan 27, 2018
@MartinNowak MartinNowak deleted the warnings branch January 28, 2018 23:17
@MartinNowak
Copy link
Copy Markdown
Member Author

Makes sense, but we probably want to use -de on the auto-tester as it leaves a bad imagine if our core tools have deprecation messages and if they aren't fixed by the one who introduces the deprecation, no one will care.

Seems fair to push the deprecation cleanup effort for any dlang code onto the PR that introduces them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants