rdmd: support -of=... and -od=... flags as well as -of... and -od...

[WebDrake]

This fixes a discrepancy between rdmd and dmd in terms of the output flags they support: dmd now requests -of=... and -od=... in help output but still supports the old -of... and -od... style, while rdmd was still supporting only the older variant.

The fix itself is a bit of a hacky tweak to the dashOh callback used to parse -o flags via getopt. It seemed the simplest way to fix the issue without a more intrusive rewrite of how -o flags are parsed.

Extra test cases have been added to rdmd_test to cover this, although the way this has been done is a little bit cheeky too (it turns out the only place where -of and -od are really tested rigorously in their behaviour is in tests for the case where the output file is a library in a subdirectory). Probably at some point it would be a good idea to add some more general/rigorous test cases for the -o... flags, but in the short term the tests added in this patch should validate the changes to rdmd itself.

[dlang-bot]

Thanks for your pull request and interest in making D better, @WebDrake! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[WebDrake]

This is just a small issue that I noticed while working on some refactoring goals. It seemed better to fix it sooner rather than later. Would this be worth adding an issue and/or changelog entry over?

[WebDrake]

Updated the commit message & PR description with a bit more context for the reason behind the fix.

[CyberShadow]

Thanks. I think this is more code than necessary, how about this:

    // Parse the -o option (-ofmyfile or -odmydir).
    void dashOh(string key, string value)
    {
        if (value.skipOver("f"))
        {
            // -ofmyfile passed
            value.skipOver("=");
            exe = value;
        }
        else if (value.skipOver("d"))
        {
            // -odmydir passed
            value.skipOver("=");
            if (!exe.ptr) // Don't let -od override -of
            {
                // add a trailing dir separator to clarify it's a dir
                exe = value;
                if (!exe.endsWith(dirSeparator))
                {
                    exe ~= dirSeparator;
                }
                assert(exe.endsWith(dirSeparator));
            }
        }
        else if (value == "-")
        {
            // -o- passed
            enforce(false, "Option -o- currently not supported by rdmd");
        }
        else if (value == "p")
        {
            // -op passed
            preserveOutputPaths = true;
        }
        else
        {
            enforce(false, "Unrecognized option: " ~ key ~ value);
        }
    }

The above will also fix -o-foo being incorrectly accepted.

[WebDrake]

Oh, interesting thought. Yup, I can rewrite along those lines if it's convenient.

The above will also fix -o-foo being incorrectly accepted.

Ah, right. The whole value[0] check in the original is indeed problematic like this. A good case for your approach.

[CyberShadow]

Thanks!

[WebDrake]

Wait wait! I have a small tweak I want to make :-P

[WebDrake]

Updated. Super picky on my part, but I wanted to tweak the commit messages slightly ;-)

[CyberShadow]

Alrighty :)

[WebDrake]

No changelog entry needed?

[CyberShadow]

Subjective, but this seems minor enough that I wouldn't call it required. A linked Bugzilla issue would be OK too.

[WebDrake]

Let's not worry about it, then, since auto-merge is already on. Thanks!

[UplinkCoder]

@WebDrake Congrats!

[Geod24]

This PR fixed issue 17064.