Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 13345 - Add argument support to rdmd --eval #408

Merged
merged 1 commit into from Jun 5, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jun 5, 2020

Some issues are easier to fix that to transfer.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
13345 enhancement rdmd --eval doesn't support args

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + tools#408"

@thewilsonator
Copy link
Contributor

Tests?

rdmd_test.d Outdated Show resolved Hide resolved
@Geod24
Copy link
Member Author

Geod24 commented Jun 5, 2020

Tests?

Should be fixed now. For some reason I was staring at the wrong line.

@MoonlightSentinel
Copy link
Contributor

This should probably also work with --loop? (To keep both flags consistent)

@Geod24
Copy link
Member Author

Geod24 commented Jun 5, 2020

I barely touch rdmd so I defer that question to someone else. @NilsBossung / @marler8997 ?

@dlang-bot dlang-bot merged commit ab39874 into dlang:master Jun 5, 2020
@Geod24 Geod24 deleted the fix13345 branch June 6, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants