Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate "generated" dir, fixing dustmite build on OSX #74

Merged
merged 1 commit into from
Aug 12, 2013

Conversation

Abscissa
Copy link
Contributor

Adjusted the makefiles to put generated files into their own separate "generated" directory, much like phobos's posix makefile.

Aside from cleanliness, this is needed to avoid an OSX build problem with dustmite: OSX is case-insensitive so the "dustmite" build target conflicted with the "DustMite" directory.

WalterBright added a commit that referenced this pull request Aug 12, 2013
Separate "generated" dir, fixing dustmite build on OSX
@WalterBright WalterBright merged commit 77cb68c into dlang:master Aug 12, 2013
# For now, 32 bit is the default model
ifeq (,$(MODEL))
MODEL:=32
endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we adopt the MODEL:=default behavior from druntime and phobos.

MODEL:=default
ifneq (default,$(MODEL))
      MODEL_FLAG:=-m$(MODEL)
endif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea, but I wasn't immediately sure how to do that (in the other repos it seemed to involve automatic re-invoking of make) and the really important thing was to get the executables out of the repo's base directory. I'm sure what you suggest would be worth someone making a pull request, though.

EDIT: Oh, I didn't read that right and thought you meant "debug vs release". What I put in there for MODEL was actually copy-pasted from one of the other repos (dmd's repo, IIRC). But in any case, yea, that may be a good idea and worth someone putting together a pull req for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point here is to avoid any default architecture in the makefile and use whatever the compiler default is.
This is how we solved it for druntime and phobos and I think it makes sense here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Thu, 15 Aug 2013 13:49:37 -0700
Martin Nowak notifications@github.com wrote:

The point here is to avoid any default architecture in the makefile
and use whatever the compiler default is. This is how we solved it
for druntime and phobos and I think it makes sense here too.

Right. I have no arguments against that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants