Use std.regex.replaceAll instead of replace().

[quickfur]

replace() is now deprecated and required the regex to be compiled with
specific flags; the new API uses replaceAll().

Fixes issue 10896.

[quickfur]

The second commit isn't strictly necessary, but is a better example of proper D code. :)

[ghost]

I got confused for a second when I ran the unittests since the app seemingly got stuck, I forgot that ddemangle waits for input from stdin. If we ever add the tools to the test-suite we should make the app exit after unit-testing (perhaps by sending CTRL+C).

Alternatively this can be used:

version(unittest) { void main(string[] args) { } }
else
void main(string[] args)
{
    // Parse command-line arguments
    try
    {
...

[ghost]

Btw I'm very happy to see a replaceAll function in std.regex, the "g" option becoming non-default was a silent breaking change that I never liked.

[quickfur]

On Tue, Aug 27, 2013 at 05:41:41PM -0700, Andrej Mitrovic wrote:

I got confused for a second when I ran the unittests since the app
seemingly got stuck, I forgot that ddemangle waits for input from
stdin.
[...]

Haha, so I'm not the only one who stared at the screen for a good long
while before I realized what was happening. :) Actually it was worse, I
thought there was a bug in the unittest so I went back to revise it.

T

Bare foot: (n.) A device for locating thumb tacks on the floor.

[quickfur]

Updated code based on Martin's suggestions and rebased.

[quickfur]

Heh, just realized there was a latent bug that got fixed by the refactoring: the old code went through all the trouble to open a file specified on the command-line, only to always read from stdin instead.

[ghost]

Thanks!