From f81432b36806952b87be2efcdc2ba562a948f7f9 Mon Sep 17 00:00:00 2001
From: griffri <Griffri.Melville@digirati.com>
Date: Fri, 31 May 2024 13:46:00 +0100
Subject: [PATCH] Add further tests for disabled old delivery channel
 properties

---
 .../Converters/LegacyModeConverterTests.cs    | 99 ++++++++++++++++++-
 1 file changed, 98 insertions(+), 1 deletion(-)

diff --git a/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs b/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs
index 9e40c82a5..74769fd35 100644
--- a/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs
+++ b/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs
@@ -111,7 +111,7 @@ public void VerifyAndConvertToModernFormat_ModelIdSet_WhenNoModelId()
     }
 
     [Fact]
-    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelEmulationDisabled()
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForImage()
     {
         // Arrange
         var hydraImage = new Image()
@@ -127,6 +127,103 @@ public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliver
         convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
     }
     
+    [Theory]
+    [InlineData("fast-higher")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/fast-higher")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForImage(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Image,
+            Origin = "something.jpg",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+    
+    [Fact]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForVideo()
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp4",
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+    
+    [Theory]
+    [InlineData("video-max")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/video-max")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForVideo(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp4",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+    
+    [Fact]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForAudio()
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp3",
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+    
+    [Theory]
+    [InlineData("audio-max")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/audio-max")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForAudio(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp3",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+    
     [Fact]
     public void VerifyAndConvertToModernFormat_AddsDeliveryChannels_WhenNotSet_ForImage()
     {