Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #35

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Support Python 3 #35

merged 2 commits into from
Dec 13, 2019

Conversation

sp1thas
Copy link
Contributor

@sp1thas sp1thas commented Nov 28, 2019

This PR is about migrate sphinx-server to Python 3 (related with #34 )

Due to the fact that I'm not familiar with Travis please take a closer look at .travis.yml file, I'm not sure if it is configured right.

@quentinus95
Copy link
Member

Hi @sp1thas, thanks for your contribution. When testing the new image, I'm getting the following error:

Traceback (most recent call last):
  File "/opt/sphinx-server/server.py", line 101, in <module>
    key = base64.b64encode(auth)
  File "/usr/local/lib/python3.8/base64.py", line 58, in b64encode
    encoded = binascii.b2a_base64(s, newline=False)
TypeError: a bytes-like object is required, not 'str'

When used with the following configuration:

autobuild: false
credentials:
  username: hello
  password: world

@quentinus95
Copy link
Member

I'm also getting the following warnings:

/opt/sphinx-server/server.py:64: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  configuration = yaml.load(config_stream)
/opt/sphinx-server/server.py:68: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  configuration.update(yaml.load(custom_stream))

@sp1thas
Copy link
Contributor Author

sp1thas commented Dec 11, 2019

Hi @quentinus95

last commit seems to fix the issues.

@quentinus95
Copy link
Member

Looks good to me, thanks @sp1thas!

@quentinus95 quentinus95 merged commit 1b723b5 into dldl:master Dec 13, 2019
@quentinus95 quentinus95 mentioned this pull request Dec 13, 2019
@sp1thas sp1thas mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants