Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale connection reconnection handling #37

Merged
merged 1 commit into from Apr 22, 2015

Conversation

@ryan-lane
Copy link
Contributor

@ryan-lane ryan-lane commented Apr 21, 2015

No description provided.

@ryan-lane
Copy link
Contributor Author

@ryan-lane ryan-lane commented Apr 21, 2015

The current check for whether a socket is alive or not isn't sufficient. It never fails, even if NSQ is unreachable. This change checks for stale connections and reconnects. Assuming the library is keeping up with the heartbeats or receiving data, it'll never need to reconnect due to staleness.

dlecocq pushed a commit that referenced this issue Apr 22, 2015
Add stale connection reconnection handling
@dlecocq dlecocq merged commit 562a292 into dlecocq:master Apr 22, 2015
1 check passed
@dlecocq
Copy link
Owner

@dlecocq dlecocq commented Apr 22, 2015

Looks good. Thanks!

@ryan-lane ryan-lane deleted the stale-connection-handling branch Apr 22, 2015
@ryan-lane ryan-lane restored the stale-connection-handling branch Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants