Commits on Sep 3, 2009
  1. @NZKoz

    Prepare for 2.3.4 release

    NZKoz committed Sep 4, 2009
  2. @NZKoz

    Clean tag attributes before passing through the escape_once logic.

    Addresses CVE-2009-3009
    NZKoz committed Aug 31, 2009
  3. @Manfred @NZKoz

    Add verify and clean methods to ActiveSupport::Multibyte.

    When accepting character input from outside of your application you can't
    blindly trust that all strings are properly encoded. With these methods
    you can check incoming strings and clean them up if necessary.
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
    Manfred committed with NZKoz Aug 26, 2009
  4. @codahale @NZKoz

    Fix timing attack vulnerability in ActiveSupport::MessageVerifier.

    Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC.
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
    codahale committed with NZKoz Aug 13, 2009
Commits on Sep 2, 2009
  1. @jeremy

    Revert "Assert primary key does not exist in habtm when the associati…

    …on is defined, instead of doing that everytime a record is inserted."
    
    Test failures on PostgreSQL.
    
    [#3128]
    
    This reverts commit 594a281.
    jeremy committed Sep 2, 2009
Commits on Sep 1, 2009
  1. @josevalim @jeremy

    Assert primary key does not exist in habtm when the association is de…

    …fined, instead of doing that everytime a record is inserted.
    
    [#3128 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    josevalim committed with jeremy Sep 1, 2009
  2. @gbuesing @jeremy

    Rails::Info doesn't require version for unwanted frameworks

    [#3124 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    gbuesing committed with jeremy Aug 31, 2009
Commits on Aug 31, 2009
  1. @josh

    Deprecated "best fit" detection is to difficult. Just provide a switc…

    …h to toggle the new behavor on.
    
      # new_rails_defaults.rb
      ActionController::Routing.generate_best_match = false
    josh committed Aug 31, 2009
  2. @josh

    Duplicating the options hash in Date#advance to prevent modification …

    …of the original [#1133 state:resolved]
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
    Jay Pignata committed with josh Aug 31, 2009
Commits on Aug 30, 2009
  1. @atd @jeremy

    I18n support for plugins

    Rails will now automatically add locale files found in any engine's locale
    directory to the I18n.load_path (i.e. files that match the glob pattern
    "config/locales/**/*.{rb,yml}" relative to engine directories).
    
    [#2325 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    atd committed with jeremy Mar 24, 2009
  2. @jeremy

    Ensuring that a singular model name is set for use in controllers whe…

    …n scaffold is passed a plural model name
    
    [#3062 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    Jay Pignata committed with jeremy Aug 16, 2009
  3. @thewoolleyman @jeremy

    CI config updates: do not send CI emails unless explicitly enabled, u…

    …se 'gem update --system', and send emails from an address which can post to the core list
    
    [#3116 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    thewoolleyman committed with jeremy Aug 29, 2009
Commits on Aug 29, 2009
  1. @jeremy

    Fix ActiveRecord Error message I18n:

    * allow messages and full_messages to be lazily translated at any time
    * allow locales to be swapped and still obtain correctly localized messages
    * allow localized global and error-type specific full_message formats
    * extract an Error class
    
    [#1687 state:open]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    Sven Fuchs + Mateo Murphy committed with jeremy Aug 22, 2009
Commits on Aug 28, 2009
  1. @jeremy
Commits on Aug 27, 2009
  1. @packagethief @jeremy

    When running multiple test tasks, don't abort early if one produces f…

    …ailures
    
    [#3107 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    packagethief committed with jeremy Aug 27, 2009
Commits on Aug 26, 2009
  1. @packagethief @jeremy

    Don't use AR::Base.connection for fixture column quoting. Use the con…

    …nection given to Fixtures.new
    
    [#3104 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    packagethief committed with jeremy Aug 26, 2009
  2. @packagethief @jeremy

    UrlRewriter#rewrite_url should call #to_param on the value given in :…

    …anchor option, just as #url_for does
    
    [#2746 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    packagethief committed with jeremy Jun 2, 2009
  3. @amatsuda @jeremy

    I18n: use I18n for select helpers' prompt text

    [#2252 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    amatsuda committed with jeremy Aug 26, 2009
  4. @jeremy

    Revert "I18n: use I18n for select helpers' prompt text"

    Broke CI.
    
    [#2252 state:open]
    
    This reverts commit d725ad3.
    jeremy committed Aug 26, 2009
  5. @svenfuchs @jeremy

    allow ActiveRecord#RecordInvalid exception message to be localized

    [#2754 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    svenfuchs committed with jeremy Aug 26, 2009
  6. @amatsuda @jeremy

    I18n: use I18n for select helpers' prompt text

    [#2252 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    amatsuda committed with jeremy Aug 26, 2009
Commits on Aug 25, 2009
  1. @jeremy

    Fix typo

    jeremy committed Aug 25, 2009
  2. @miloops @jeremy

    timestamps gives a created_at field not created_on.

    [#3093 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    miloops committed with jeremy Aug 24, 2009
  3. @jeremy
Commits on Aug 24, 2009
  1. @jeremy
Commits on Aug 20, 2009
  1. @ffmike @lifo

    Fix trivial typo in template runner example [#3082 state:resolved]

    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
    ffmike committed with lifo Aug 20, 2009
Commits on Aug 18, 2009
  1. @dhh @lifo

    Added db/seeds.rb as a default file for storing seed data for the dat…

    …abase. Can be loaded with rake db:seed (or created alongside the db with db:setup). (This is also known as the "Stop Putting Gawd Damn Seed Data In Your Migrations" feature) [DHH]
    
    Conflicts:
    
    	railties/CHANGELOG
    dhh committed with lifo Aug 18, 2009
Commits on Aug 17, 2009
  1. @lifo
Commits on Aug 16, 2009
  1. @jeremy
  2. @jeremy
  3. @FooBarWidget @jeremy

    Fix reloading of metal pieces.

    - Do not hold references to old metal objects after metal classes have been reloaded.
    - Obtain the reloader lock before building the middleware stack, so that reloading of metal pieces works in the face of multithreading.
    
    [#2873 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    FooBarWidget committed with jeremy Aug 11, 2009
Commits on Aug 15, 2009
  1. @jeremy

    Adding a call to logger from params_parser to give detailed debug inf…

    …ormation when invalid xml or json is posted
    
    [#2481 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    Jay Pignata committed with jeremy Aug 13, 2009
  2. @jeremy
  3. @jeremy

    Refine the deprecated route check to explicitly check whether the fut…

    …ure route pick comes before the deprecated route that was found.
    jeremy committed Aug 15, 2009
  4. @rubymerchant @lifo

    Fix ActiveResource load test for 64bit machines [#3051 state:resolved]

    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
    rubymerchant committed with lifo Aug 14, 2009