Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable ServiceTicketValidator #31

Closed
alksl opened this issue Aug 19, 2014 · 4 comments
Closed

Pluggable ServiceTicketValidator #31

alksl opened this issue Aug 19, 2014 · 4 comments

Comments

@alksl
Copy link

alksl commented Aug 19, 2014

Hi

Is it possible to make the ServiceTicketValidator overridable ?. I have a use case where I need to fetch additional user data from other sources.

Either by supplying a block or an alternative object. For example by removing this hardcoded classname.
https://github.com/dlindahl/omniauth-cas/blob/master/lib/omniauth/strategies/cas.rb#L74

@dlindahl
Copy link
Owner

@alksl Do you still need this feature?

@alksl
Copy link
Author

alksl commented Sep 25, 2014

Yes, I made some experiments here alksl@d62e107

It is now used in production where the block fetches some data from LDAP and does a merge in omniauth. Not sure how to test it though.

Is this something that could be accepted ? or is it to much of an edge case ?

@dlindahl
Copy link
Owner

See the README for details. Let me know what you think or if its not clear!

@alksl
Copy link
Author

alksl commented Sep 30, 2014

Looks good, ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants