Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove python 2 code #43

Merged
merged 2 commits into from May 20, 2022

Conversation

jkklapp
Copy link
Contributor

@jkklapp jkklapp commented May 16, 2022

part of #40

@mschwager
Copy link
Contributor

Hi there,

Good idea, thanks for taking this on! Since this is a large PR, please allow some additional time for review.

Briefly looking over the PR, can you remove changes unrelated to removing Python 2.7 code? We can move single -> double quotes, shift whitespace around, etc, but that would be easier to do in a separate change, and would make review of this code easier.

Thanks again!

@jkklapp jkklapp force-pushed the refactor/remove-python-2-code branch from dccb7dd to 987236e Compare May 17, 2022 15:21
@jkklapp jkklapp force-pushed the refactor/remove-python-2-code branch from 987236e to ce0abed Compare May 17, 2022 15:27
@jkklapp
Copy link
Contributor Author

jkklapp commented May 20, 2022

@mschwager I made the changes you requested

@mschwager
Copy link
Contributor

Excellent, thanks again!

@mschwager mschwager merged commit fcadc1b into dlint-py:master May 20, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants