-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(requirements): Support flake8 v5 #46
Conversation
I am guessing that this is what is stuffing up those tests: PyCQA/flake8#1609 Not sure the best way around that... I don't think it causes any issues, but does mean a few tests aren't quite valid anymore. Also, given how infrequently this project is updated, perhaps the flake8 upper bound should just be completely removed? |
Yes, those The changelog states (https://flake8.pycqa.org/en/latest/release-notes/5.0.0.html):
Is this just a matter of updating the defaults in |
@mschwager changing the defaults in Currently the And I'm not sure that the extended_default_select option can be tested using the current test methods. The extended_default_select setting doesn't appear to have any affect on the I'm not entirely sure how important the extended_default_select test is for dlint. Nor how important the behaviour of get_linter_classes() is with different option args so I'm not sure what the best way forward is for that test. |
Thanks for digging into this. Now I remember where I got the initial Copying the latest That change shouldn't affect any functionality in Dlint. Since |
Ah yep, awesome. Sounds good to me. |
More details about changes: #46
Good morning everyone 👋 |
It passed! Thanks again for the PR, I will cut a new release of Dlint now 👍 |
Closes #45