Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-sass to 3.0 #207

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Keats
Copy link
Collaborator

Keats commented Mar 13, 2015

node-sass removed success/error callback
sass/node-sass#726
Switched them to a single callback function

It also now returns buffer instead of string.

See https://github.com/sass/node-sass/releases for list of changes

Note: there is a hack for the obj.css with sourcemap, not
sure what to do there

Vincent Prouillet
Update node-sass to 3.0
node-sass removed success/error callback
sass/node-sass#726
Switched them to a single callback function

It also now returns buffer instead of string.

See https://github.com/sass/node-sass/releases for list of changes

Note: there is a hack for the obj.css with sourcemap, not
sure what to do there
if (obj.map && obj.map instanceof Buffer) {
// hack to remove the already added sourceMappingURL from libsass
// TODO: this is now a buffer, what to do here?
obj.css = obj.css.toString().replace(/\/\*#\s*sourceMappingURL\=.*\*\//, '');

This comment has been minimized.

@Keats

Keats Mar 13, 2015

Author Collaborator

here, if someone that knows about how sourcemap work, would it be ok like that?

@Keats Keats referenced this pull request Mar 13, 2015

Closed

Bump node-sass to 3.0.0 #206

@kooparse

This comment has been minimized.

Copy link

kooparse commented Mar 13, 2015

Thanks ;)

@ifraixedes

This comment has been minimized.

Copy link

ifraixedes commented Mar 15, 2015

I haven't reviewed the changes and node-sass change log either, but I've tested the plugin with some sass files and iojs 1.5.1 and works as a charm

Vincent Prouillet

@Keats Keats referenced this pull request Mar 20, 2015

Closed

Add New Collaborators #213

@Snugug

This comment has been minimized.

Copy link
Collaborator

Snugug commented Mar 23, 2015

Resolves #210

@Keats Keats closed this Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.