Internal function valid-timestamp-p could be smarter about restricting the valid integer range for YEAR arg #3

Open
mon-key opened this Issue Apr 9, 2012 · 1 comment

Projects

None yet

1 participant

@mon-key
mon-key commented Apr 9, 2012

Internal function valid-timestamp-p could be smarter about restricting the valid integer range for YEAR arg.

local-time::valid-timestamp-p 000001 0 0 0 28 2 most-positive-fixnum)
;=> T

(local-time::valid-timestamp-p 000001 0 0 0 29 2 most-positive-fixnum)
;=> NIL

(local-time:encode-timestamp 000001 0 0 0 29 2 most-positive-fixnum)
;=> error

(local-time:encode-timestamp 000001 0 0 0 28 2 most-positive-fixnum)
;=> error

mon-key commented Apr 9, 2012

I've posted some some suggestions for the above and for tweaking local-time in general at following gist:
https://gist.github.com/2340654
git://gist.github.com/2340654.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment